-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serializing issues in planned maintenance #253
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 3 files 3 suites 52s ⏱️ Results for commit 2c18a57. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 50 50
Lines 6740 6740
=======================================
Hits 6672 6672
Misses 68 68 ☔ View full report in Codecov by Sentry. |
I think it would be nice, just for the person creating the release to be able to group this and the original PM PR together |
If there hasn't been a release (as in: on pypi) of the pm functionality then I don't see why there needs to be something grouped together. Then again, I don't see why mentioning PR numbers in the chaneglog are necessary. |
Quality Gate passedIssues Measures |
Bugfixes for planned maintenance added in #194 (for #61)
Fixes the ol' Pydantic problem where it struggles with subclasses if you dont specifically mention the subclasses instead of just referencing the parent. Adds some default values as there were some issues reading state back in if something was set to None but didnt have default value, I'm guessing None values arent written to the file.
Also changes how the
type
field for PMs are defined, as pydantic struggled to recreate the object with the correct subclass ifLiteral
wasnt being usedDoes this need a towncrier file?